deploy-cloudrun icon indicating copy to clipboard operation
deploy-cloudrun copied to clipboard

feat: added env_vars_file input to set env variables

Open phbs1lva opened this issue 3 years ago • 1 comments

Added env_vars_file option to set environment variables.

Related to #234

phbs1lva avatar Sep 13 '22 18:09 phbs1lva

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 13 '22 18:09 google-cla[bot]

So two things on this...

  1. gcloud exposes an --env-vars-file flag that could cause confusion to users

  2. This deviates from how gcloud implements the --env-vars-file flag (details here).

I would much rather see the flags input used to set the --env-vars-file that is natively exposed by gcloud.

verbanicm avatar Nov 03 '22 14:11 verbanicm