deploy-appengine icon indicating copy to clipboard operation
deploy-appengine copied to clipboard

Add support for `cloud_build_timeout`

Open selfagency opened this issue 3 years ago • 4 comments

TL;DR

Add a flag for cloud_build_timeout

Detailed design

If you are deploying from the command line, you could change the Cloud Build timeout setting like so:

gcloud config set app/cloud_build_timeout 1000

There's no way to do so with the current workflow. So this is a request to add support for cloud_build_timeout so that I can use it like so:

      - id: deploy
        name: Deploy to Google App Engine
        uses: google-github-actions/deploy-appengine@v0
        with:
          cloud_build_timeout: ${{ env.BUILD_TIMEOUT }}
          deliverables: api.yaml
          promote: true
          image_url: ${{ env.IMAGE_NAME }}

Additional information

No response

selfagency avatar Feb 02 '22 17:02 selfagency

Thanks for the report @selfagency As a workaround you may also be able to use an env var like https://cloud.google.com/sdk/docs/properties#setting_properties_using_environment_variables since its a CLI property and not a flag

bharathkkb avatar Feb 02 '22 21:02 bharathkkb

ah thanks, will do

selfagency avatar Feb 02 '22 22:02 selfagency

@bharathkkb Could you maybe share some light on how to add cloud_build_timeout as env var to google-github-actions/deploy-appengine action yaml

andrijavulicevic avatar Jun 07 '22 09:06 andrijavulicevic

For anyone searching the solution seems like this passes the timeout var to Cloud Build:

- name: My Deploy Step
    uses: google-github-actions/[email protected]
    with:
      ... my deliverables & config
    env:
      CLOUDSDK_APP_CLOUD_BUILD_TIMEOUT: 1200

andrijavulicevic avatar Jun 07 '22 11:06 andrijavulicevic