generative-ai-python icon indicating copy to clipboard operation
generative-ai-python copied to clipboard

Improve key naming clarity and consistency across REST requests #683

Open demoncoder-crypto opened this issue 8 months ago • 4 comments

… Standardize on camelCase for REST API parameter names - Update README.md to document parameter naming conventions - Create new inline_pdf_example.sh with consistent naming - Fix inconsistent naming in several example files - Fixes #683

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • [x] I have performed a self-review of my code.
  • [x] I have added detailed comments to my code where applicable.
  • [x] I have verified that my change does not break existing code.
  • [x] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [x] I am familiar with the Google Style Guide for the language I have coded in.
  • [x] I have read through the Contributing Guide and signed the Contributor License Agreement.

demoncoder-crypto avatar Mar 11 '25 01:03 demoncoder-crypto

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 11 '25 01:03 google-cla[bot]

I have made the asked changes let me know if its upto mark

demoncoder-crypto avatar Mar 11 '25 01:03 demoncoder-crypto

Looks good to me but I believe these examples need to be verified and tested by someone internal to Google before they can proceed with merging the PR and closing the issue.

ossa-ma avatar Mar 11 '25 01:03 ossa-ma

Thanks. If anything else is needed or any changes. I am always up for it

demoncoder-crypto avatar Mar 11 '25 01:03 demoncoder-crypto