dm_control icon indicating copy to clipboard operation
dm_control copied to clipboard

PyMJCF nested include tags relative to base model

Open guyazran opened this issue 2 years ago • 2 comments

Addresses #418

guyazran avatar Aug 03 '23 10:08 guyazran

Hi @guyazran , did you happen to test this out before making your Pull Request here?

e.g. on the example you provided here: https://github.com/google-deepmind/dm_control/issues/418

I am also interested in composing XML files with PyMJCF which support nested include tags, and i'm hoping to revive this issue so things can be resolved for us and others.

jonzamora avatar May 26 '24 14:05 jonzamora

Hi @jonzamora. Thanks for reviving this PR. It will make running with nested include tags much smoother.

I sent this PR in a long time ago, but I can definitely say that at the time of creating the PR and when I wrote "addresses #418" the example scene in that issue ran smoothly.

However, this might be a pointless effort because in another issue the creators said that they are working on a different solution #407. perhaps you should ping there and see how the alternative solution is working

guyazran avatar May 28 '24 05:05 guyazran