vscode-go icon indicating copy to clipboard operation
vscode-go copied to clipboard

docs/gopath.md: fix broken link to VSCode Workspace Settings docs

Open Russ741 opened this issue 1 year ago • 7 comments

Use https://code.visualstudio.com/docs/getstarted/settings#_workspace-settings

Russ741 avatar Jun 24 '24 17:06 Russ741

This PR (HEAD: 8f845eef4767ec43148941d7c647cd47dcd239c9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/594535.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Jun 24 '24 17:06 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/594535. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 24 '24 17:06 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/594535. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 24 '24 17:06 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/594535. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 24 '24 22:06 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 1: -Code-Review


Please don’t reply on this GitHub thread. Visit golang.org/cl/594535. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 24 '24 22:06 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/594535. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 25 '24 16:06 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/594535. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 25 '24 16:06 gopherbot

I can't link my GitHub account to Gerrit (whoops); I'll resubmit as a separate CL with the right account.

Russ741 avatar Jul 19 '24 15:07 Russ741