vscode-go icon indicating copy to clipboard operation
vscode-go copied to clipboard

Published 20 hours ago • verified publisher icon golang

src/goTest: fix multifile suite test fails to debug

Open nirhaas opened this issue 3 years ago • 32 comments

Collect a packages suites and maps their name with the caller function. This mapping is used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run).

Fixes golang/vscode-go#2414

nirhaas avatar Aug 15 '22 23:08 nirhaas

This PR (HEAD: 1a9b381caf507a41f7049a91d3746a9d041e7304) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Aug 15 '22 23:08 gopherbot

Message from Suzy Mueller:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 18 '22 18:08 gopherbot

This PR (HEAD: 1ab294700b3a397fdb259b69f5789bf746d5b593) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Aug 18 '22 19:08 gopherbot

Message from Nir Haas:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 18 '22 20:08 gopherbot

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 18 '22 20:08 gopherbot

Message from Nir Haas:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 18 '22 20:08 gopherbot

Message from Nir Haas:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 25 '22 19:08 gopherbot

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 29 '22 18:08 gopherbot

Message from Suzy Mueller:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 01 '22 13:09 gopherbot

This PR (HEAD: c97e66195ea0576a828d0932ebddf216b1e37f18) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Sep 02 '22 19:09 gopherbot

This PR (HEAD: 09deeca26784f7adea72f400c5b2013865aacebb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Sep 02 '22 19:09 gopherbot

Message from Nir Haas:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 02 '22 19:09 gopherbot

Message from Nir Haas:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 04 '22 18:09 gopherbot

Message from Suzy Mueller:

Patch Set 4: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 12 '22 16:09 gopherbot

Message from Suzy Mueller:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 12 '22 18:09 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 4: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 12 '22 19:09 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 4: Run-TryBot+1 -Auto-Submit

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 12 '22 19:09 gopherbot

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/16780e7b-5957-419f-96ae-b57ac3fcc7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 12 '22 19:09 gopherbot

Message from kokoro:

Patch Set 4: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/16780e7b-5957-419f-96ae-b57ac3fcc7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 12 '22 19:09 gopherbot

Message from Jamal Carvalho:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 14 '22 16:09 gopherbot

This PR (HEAD: 19b8cd4bc5c29450a2e2592ad8ff790be8219e2e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Sep 14 '22 17:09 gopherbot

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 14 '22 17:09 gopherbot

Message from Jamal Carvalho:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 19 '22 14:09 gopherbot

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/a26112ed-f26d-470f-8b28-d0868baa3efa

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 19 '22 14:09 gopherbot

Message from kokoro:

Patch Set 5: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/a26112ed-f26d-470f-8b28-d0868baa3efa

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 19 '22 17:09 gopherbot

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 20 '22 08:09 gopherbot

Message from Jamal Carvalho:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 20 '22 13:09 gopherbot

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/0cf44da8-6f10-428d-868b-1a378fe664c9

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 20 '22 13:09 gopherbot

Message from kokoro:

Patch Set 5: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/0cf44da8-6f10-428d-868b-1a378fe664c9

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 20 '22 14:09 gopherbot

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 03 '22 09:10 gopherbot