vscode-go
vscode-go copied to clipboard
golang
testExplorer: skip test files in testdata directory
From go help test:
The go tool will ignore a directory named "testdata", making it available to hold ancillary data needed by the tests.
Currently, vscode-go test provider collects tests from files under 'testdata' directories. They need to be skipped.
CC @firelizzard18
@hyangah, this seems like it should be on deck. Please amend if not.
It's crunch time at my day job, so my availability is limited.
GoTestResolver.resolve should be updated to skip directories named 'testdata', but with that alone, if a user opens a '_test.go' file within a 'testdata' directory, tests in that file will still be resolved. I think the best way to avoid that would be to return early from GoTestResolver.processDocument if the document's URL includes a directory named 'testdata'. I think that should cover everything.
An alternative approach would be returning early from GoTestResolver.getOrCreateItem if the URL includes 'testdata'. However, IIRC callers of getOrCreateItem do not expect it to return null. Though that is how the exclude support works, so this might be a viable alternative after merging that CL.
This is not an urgent issue IMO. Moved to Unplanned for now.
GoTestResolver.processDocument approach seems reasonable to me. I will label it as help-wanted. :-)
@hyangah With #59445, do you think this should be handled by gopls or vscode-go?