perf icon indicating copy to clipboard operation
perf copied to clipboard

chore: unnecessary use of fmt.Sprintf

Open testwill opened this issue 2 years ago • 3 comments

testwill avatar Aug 04 '23 02:08 testwill

This PR (HEAD: a6b846b22e41b06e93e6c9b0a386a512bd06cf1b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/perf/+/515835.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Aug 04 '23 02:08 gopherbot

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 08 '23 05:08 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 08 '23 21:08 gopherbot

This PR (HEAD: 9f031f6288a9b535c5eef93e44c5ff94baa1e936) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/perf/+/515835.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar May 09 '24 05:05 gopherbot

Message from guoguangwu guo:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 05:05 gopherbot

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 19:05 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-09T19:17:18Z","revision":"62ffd6082349d6358bfa77a31f9e30bcb9c35198"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 19:05 gopherbot

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 19:05 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 19:05 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/515835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 19:05 gopherbot

This PR is being closed because golang.org/cl/515835 has been merged.

gopherbot avatar May 10 '24 02:05 gopherbot