oauth2 icon indicating copy to clipboard operation
oauth2 copied to clipboard

oauth2: add device flow support

Open marcusirgens opened this issue 3 years ago • 3 comments

Resolves merge conflicts in #356.

Also fixes some issues:

  • Stops polling when the server responds with an unexpected error
  • Uses correct types for the expires_in and interval properties in the Device Authorization Response

Resolves #418.

marcusirgens avatar Feb 16 '22 21:02 marcusirgens

Brilliant timing. I just checked Golang for support of the device flow today.

anderspitman avatar Feb 18 '22 17:02 anderspitman

Brilliant timing. I just checked Golang for support of the device flow today.

I encountered some bugs while testing this code, @anderspitman. Please let me know if you encounter any unexpected behaviour. I'll try to write some tests this weekend.

marcusirgens avatar Feb 19 '22 18:02 marcusirgens

@marcusirgens unfortunately I'm implementing a custom OAuth2 server, so I might wait until this is stable before using it, and might not be much help in testing. But if I do end up giving it a try I'll let you know.

anderspitman avatar Feb 21 '22 18:02 anderspitman

Implemented in https://github.com/golang/oauth2/commit/e3fb0fb3af0ee7c0c62e31c393cbcfce6b2af5bf

hickford avatar Sep 07 '23 22:09 hickford