oauth2
oauth2 copied to clipboard
golang
oauth2: return error if error field is present in access token response
Return an error containing the error, error_description, and error_uri when the error field is present in the access token response, even if the HTTP response code is 2xx.
Fixes #441
This PR (HEAD: 605770292164aba6b415b7b243a20006ac97b90d) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/oauth2/+/261220 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/261220. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/261220. After addressing review feedback, remember to publish your drafts!
Related issue https://github.com/golang/oauth2/issues/274 (reported by me long ago), I guess this one will get fixed as well.
Came here because Slack does something similar and there's no way to know exactly what the error is. What's missing from this being merged?
Hello @codyoss, Is there any timeline as to when this PR will be finally approved and merged? If not, there should be some other way for dealing with OAuth2 errors coming in 200-code responses. Debugging errors in production has been much harder without being able to see those.
Also find it quite cumbersome not being able to get the error. Can this be merged?
@bradfitz Can you take a look or assign a new reviewer? https://go-review.googlesource.com/c/oauth2/+/261220
Could https://github.com/golang/oauth2/commit/cfe200d5bb2f300f7e51d5259d993d035b3d11b3 have been an equivalent fix?
