mod icon indicating copy to clipboard operation
mod copied to clipboard

Hash1: Make comment more precisely describe how to emulate logic from shell

Open charles-dyfis-net opened this issue 3 years ago • 5 comments

The shell command previously given as an example emits paths starting with ./, and without an added prefix. Also, previously, sha256 was run against the sorted list of filenames, not against the contents of those files (xargs is needed to perform the latter).

This does introduce a GNUism; working with POSIX find might involve adding a sed pipeline element.

charles-dyfis-net avatar Mar 22 '22 22:03 charles-dyfis-net

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 22 '22 22:03 google-cla[bot]

This PR (HEAD: abcd998d737f9cf77ac9f7b3154f78f350ed533e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/394894 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 22 '22 23:03 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/394894. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 22 '22 23:03 gopherbot

Message from Bryan Mills:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/394894. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 31 '22 21:03 gopherbot

Message from Bryan Mills:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/394894. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 21 '22 20:09 gopherbot