mock icon indicating copy to clipboard operation
mock copied to clipboard

Support type-safe return values

Open tra4less opened this issue 3 years ago • 10 comments

tra4less avatar Mar 11 '22 08:03 tra4less

#622 #427 #634 #657

tra4less avatar Mar 11 '22 08:03 tra4less

Hi, is there any progress on this PR?

danielvladco avatar Apr 12 '22 11:04 danielvladco

Hey, any updates here?

cc @codyoss

falsaffa avatar Apr 23 '22 06:04 falsaffa

any progress on this?

trim21 avatar May 11 '22 13:05 trim21

Hey @codyoss , is there anything @n0trace/we/anyone can do to help get this PR reviewed and approved?

falsaffa avatar Jun 05 '22 01:06 falsaffa

The implementation changed, by adding a flag. @codyoss @Trim21 reference #622

tra4less avatar Jun 11 '22 04:06 tra4less

add new flag in readme?

trim21 avatar Jun 11 '22 05:06 trim21

@codyoss @n0trace any progress with the PR?

falsaffa avatar Jul 07 '22 13:07 falsaffa

cc @codyoss

tra4less avatar Jul 21 '22 08:07 tra4less

@codyoss Is any ETA for review of the PR?

rekby avatar Sep 06 '22 12:09 rekby

Would love to see this reviewed. Putting the feature behind a new flag seems like a good way to introduce it.

jhalterman avatar Nov 10 '22 17:11 jhalterman

/ping

trim21 avatar Jan 12 '23 06:01 trim21

Bump. This would be very useful.

alvarotuso avatar Mar 01 '23 22:03 alvarotuso

cc @codyoss

trim21 avatar May 07 '23 22:05 trim21

hi @n0trace , this also requires one additional fix for optional vars.

Example interface:

import (
	"context"
	"fmt"

	"github.com/aws/aws-sdk-go-v2/aws"
	"github.com/aws/aws-sdk-go-v2/config"
	"github.com/aws/aws-sdk-go-v2/service/s3"
)

type s3Client interface {
	HeadBucket(ctx context.Context, input *s3.HeadBucketInput, opts ...func(*s3.Options)) (*s3.HeadBucketOutput, error)
}

will generate incorrect mock Return func: image fix is https://github.com/skynet2/mock/commit/ca75ee65a535230e0f517a626f35d48646b50d0b image

Thanks

skynet2 avatar Jun 23 '23 08:06 skynet2

@codyoss can anyone review this PR?

trim21 avatar Jun 25 '23 09:06 trim21

@codyoss can anyone review this PR?

Good news: Codyoss' github is highly active. Bad news: Not active in this repository.

tra4less avatar Jun 25 '23 10:06 tra4less