gofrontend icon indicating copy to clipboard operation
gofrontend copied to clipboard

Fix range channel comments typo

Open RainbowMango opened this issue 7 years ago • 3 comments

In for-range statement, if the range expression is a channel, at most one iteration variable is permitted. The variable should be element not index.

RainbowMango avatar Nov 03 '18 09:11 RainbowMango

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Nov 03 '18 09:11 googlebot

I signed it!

在 2018-11-03 17:30:39,"googlebot" [email protected] 写道:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA Individual signers It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits. Corporate signers Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version). The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits. The email used to register you as an authorized contributor must also be attached to your GitHub account.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

RainbowMango avatar Nov 03 '18 09:11 RainbowMango

CLAs look good, thanks!

googlebot avatar Nov 03 '18 09:11 googlebot

This PR (HEAD: c8f00c173f75a2dc97499e8dfabdf08252be675d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gofrontend/+/472996 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 03 '23 01:03 gopherbot

This PR is being closed because golang.org/cl/472996 has been abandoned.

Incorrect change.

gopherbot avatar Mar 03 '23 05:03 gopherbot