go
go copied to clipboard
golang
cmd/link: fix broken DWARF LPT on trampoline architectures
Fixes: #54320
When trampolines are needed (e.g. Darwin ARM64), the DWARF LPT generation is skipped because the replacement symbols are marked as external symbols and skipped during the DWARF LPT generation phase. This change handles the case where "external" symbols are actually trampolined symbols.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR (HEAD: 7165a0789e48bc82c89882a6780f109f58e05c41) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/422154 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 1:
(6 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 8cb317aa501739aa7eef04f81fb2e934a4a1bace) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/422154 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: aa32a972dd1ce0a9dedf9bd1d14e95f2500407cc) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/422154 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Jeremy Quirke:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Jeremy Quirke:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Jeremy Quirke:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 892586e0d380264335eeb54ed56f09b08c30c10e) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/422154 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 085bbc55dbc95d55456cc2acc46a0d02416c2848) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/422154 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Jeremy Quirke:
Patch Set 6:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 6: Run-TryBot+1 Code-Review+2
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 6:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 6: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Jeremy Quirke:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Than McIntosh:
Patch Set 8: Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Than McIntosh:
Patch Set 8: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 8:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 8: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/422154. After addressing review feedback, remember to publish your drafts!