go icon indicating copy to clipboard operation
go copied to clipboard

net/http: reverseproxy: forward 1xx responses

Open dunglas opened this issue 3 years ago • 11 comments

Support for 1xx responses has recently been merged in net/http (#42597).

As discussed in this CL (https://go-review.googlesource.com/c/go/+/269997/comments/1ff70bef_c25a829a), support for forwarding 1xx responses in ReverseProxy has been extracted in this separate patch.

According to RFC 7231, "a proxy MUST forward 1xx responses unless the proxy itself requested the generation of the 1xx response". Consequently, all received 1xx responses are automatically forwarded as long as the underlying transport supports ClientTrace.Got1xxResponse.

Fixes #26088 Fixes #51914

dunglas avatar May 31 '22 17:05 dunglas

This PR (HEAD: 902f8a7377ffe4dfd144f9854b07732df900a97d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 31 '22 17:05 gopherbot

This PR (HEAD: aa23135a9d2150c4e72f0860374467043e539383) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 31 '22 17:05 gopherbot

Message from Rhys Hiltner:

Patch Set 2: Run-TryBot+1 Code-Review+1

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 31 '22 18:05 gopherbot

Message from Gopher Robot:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 31 '22 18:05 gopherbot

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 31 '22 19:05 gopherbot

Message from Damien Neil:

Patch Set 2: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 31 '22 22:05 gopherbot

This PR (HEAD: 3f2415f1d428f795bc857eee63f14dd258990106) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jun 01 '22 15:06 gopherbot

Message from Kévin Dunglas:

Patch Set 3:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 01 '22 15:06 gopherbot

This PR (HEAD: 30ee65fe74bab26bd5848859026ea98d0c3121d7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 12 '22 07:07 gopherbot

Message from Kévin Dunglas:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 08 '22 20:08 gopherbot

This PR (HEAD: 7a6b718757d1484c388259fa604f6b8df5474556) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Aug 08 '22 20:08 gopherbot

Message from Damien Neil:

Patch Set 5: Run-TryBot+1 Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 21:08 gopherbot

Message from Gopher Robot:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 21:08 gopherbot

Message from Gopher Robot:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 21:08 gopherbot

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 22:08 gopherbot

Message from Gopher Robot:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 22:08 gopherbot

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 22:08 gopherbot

Message from Damien Neil:

Patch Set 5: Auto-Submit+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 22:08 gopherbot

Message from Dmitri Shuralyov:

Patch Set 6: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 17 '22 03:08 gopherbot

Message from Dmitri Shuralyov:

Patch Set 6: Auto-Submit+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 17 '22 03:08 gopherbot

Message from Dmitri Shuralyov:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 17 '22 03:08 gopherbot

This PR (HEAD: dab8a461fb65b547306cae9b4c664e60020a8fa6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/409536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Aug 30 '22 10:08 gopherbot

Message from Kévin Dunglas:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '22 10:08 gopherbot

Message from hopehook:

Patch Set 7: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '22 13:08 gopherbot

Message from Gopher Robot:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '22 13:08 gopherbot

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/409536. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '22 13:08 gopherbot

This PR is being closed because golang.org/cl/409536 has been merged.

gopherbot avatar Sep 15 '22 00:09 gopherbot