crypto icon indicating copy to clipboard operation
crypto copied to clipboard

bcrypt: document 72-byte password length limit

Open aeneasr opened this issue 6 years ago • 9 comments

This BCrypt implementation supports a maximum password length of 72 characters. This was not documented prior which is resolved with this PR.

aeneasr avatar May 17 '19 09:05 aeneasr

This PR (HEAD: 21f59bc51cfa4505dd9f178d11e824d46101c9a7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/177818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 17 '19 09:05 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 17 '19 09:05 gopherbot

This PR (HEAD: 313e465171515032c398afa2951518fbdbbe39d5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/177818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 17 '19 09:05 gopherbot

This PR (HEAD: 79b0e9cd88b787d96b0cffa671aa7d084687633d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/177818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 17 '19 09:05 gopherbot

Anything else needed to get this merged?

aeneasr avatar Aug 04 '20 14:08 aeneasr

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot

Message from Aeneas Rekkas:

Patch Set 6: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 03 '23 01:03 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 25 '23 15:09 gopherbot

Message from Aeneas Rekkas:

Patch Set 6: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 25 '23 15:09 gopherbot