crypto
crypto copied to clipboard
golang
acme/autocert: Enable custom ports
It is mandatory to be reachable on port 443 from the public internet but it is completely fine to run a service on a different port internally and use e. g. NAT/masquerading.
Additionally I might want to bind a service not to all of my local IP addresses.
Fixes issue #29540
This PR (HEAD: 5dd1a0f47cdb1f0842ddc6b9bdc347c63f659fe1) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/155744 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Katie Hockman:
Patch Set 1: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 1:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 1: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Katie Hockman:
Patch Set 1:
Since this is a non-trivial change, please associate this change with an issue that describes the decision from the code owners. If possible, please also include/update any tests.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: f77e8f7434781556bf979bd4c1e37dcc2c19f172) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/155744 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Brad Fitzpatrick:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Axel Gluth:
Patch Set 3:
(1 comment)
Reply to comments
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Katie Hockman:
Patch Set 1: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Katie Hockman:
Patch Set 1:
Since this is a non-trivial change, please associate this change with an issue that describes the decision from the code owners. If possible, please also include/update any tests.
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Brad Fitzpatrick:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!
Message from Axel Gluth:
Patch Set 3:
(1 comment)
Reply to comments
Please don’t reply on this GitHub thread. Visit golang.org/cl/155744. After addressing review feedback, remember to publish your drafts!