crypto

crypto copied to clipboard

Reame
Issues

adding new key wrap support as per rfc 3394 and 5649

Open brhaspat opened this issue 7 years ago • 14 comments

i am closing pull request 46, because i have lost track of changes.

May 30 '18 17:05 brhaspat

By mistake i deleted the fork of my last pull reuest i.e. 46. So this is a new one.

May 30 '18 17:05 brhaspat

This PR (HEAD: ae14f156ddfd18c06270da9415c7c473c4741d0b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/crypto/+/115336 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

May 30 '18 18:05 gopherbot

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Feb 06 '19 18:02 gopherbot

Message from rajni kant:

Patch Set 1:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

No corresponding issue, this is the feature we needed in our crypto application which was build using GO. I thought it will be good to add this to Go crypto.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Feb 07 '19 04:02 gopherbot

Message from Andrew Bonventre:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Feb 07 '19 17:02 gopherbot

Message from rajni kant:

Patch Set 1:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

https://github.com/golang/go/issues/30128

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Feb 08 '19 08:02 gopherbot

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Nov 08 '21 11:11 gopherbot

Message from rajni kant:

Patch Set 1:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

No corresponding issue, this is the feature we needed in our crypto application which was build using GO. I thought it will be good to add this to Go crypto.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Nov 08 '21 11:11 gopherbot

Message from Andrew Bonventre:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Nov 08 '21 11:11 gopherbot

Message from rajni kant:

Patch Set 1:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

https://github.com/golang/go/issues/30128

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Nov 08 '21 11:11 gopherbot

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Sep 25 '23 15:09 gopherbot

Message from rajni kant:

Patch Set 1:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

No corresponding issue, this is the feature we needed in our crypto application which was build using GO. I thought it will be good to add this to Go crypto.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Sep 25 '23 15:09 gopherbot

Message from Andrew Bonventre:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Sep 25 '23 15:09 gopherbot

Message from rajni kant:

Patch Set 1:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

https://github.com/golang/go/issues/30128

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336. After addressing review feedback, remember to publish your drafts!

Sep 25 '23 15:09 gopherbot