golang
ssh/agent: parse public key with ssh.ParsePublicKey
When the server gets an agentSignRequest it can be ssh.PublicKey or ssh.Certificate formatted keys. As the server only parsed these into ssh.Key they would require a Marshal() to ParsePublicKey() dance when the passed key is a certificate.
Use ssh.ParsePublicKey instead of the ssh.Key struct directly.
This PR (HEAD: bb226e340e6c5ee66b4bf608760f9e341b8783c4) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/638237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638237. After addressing review feedback, remember to publish your drafts!