crypto icon indicating copy to clipboard operation
crypto copied to clipboard

x/crypto/argon2: Adding password hashing/verification wrapper to x/crypto/argon2

Open calvin-barker opened this issue 2 years ago • 5 comments

fixes: golang/go#60740

https://github.com/golang/go/issues/60740

calvin-barker avatar Jun 12 '23 14:06 calvin-barker

This PR (HEAD: 9b526aa57fd89380c689cac0e6c10314afba4845) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/502515 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jun 12 '23 14:06 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/502515. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 12 '23 15:06 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/502515. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 25 '23 15:09 gopherbot

This is great - I had provided my own abstraction over it to wrap bcrypt and argon2ID but this is really nice and would make swap outs easy.

17twenty avatar Jul 24 '24 05:07 17twenty

@calvin-barker are you still pushing to merge this under the CLA etc?

17twenty avatar Jul 24 '24 05:07 17twenty