all: use error wrap when possible

[sapk]

I wanted to be able to use error.Is to match io or syscall errors on ssh network error.

This is currently not possible because errors are not wrapped.

This change replace %v verb with %w in fmt.Errorf() calls.

I was looking to fix this in ssh package but found that it could be extended to other package. This change should be transparent to existing code since they can still rely on old error comparison but will provide more details in case of check with errors.Is or errors.As.

[gopherbot]

This PR (HEAD: 7527590b58dea491c161aa68953fce34aa75ca76) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/472695 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Muhammad Shulhan:

Patch Set 1: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Muhammad Shulhan:

Patch Set 1: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 1: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-30T03:19:32Z","revision":"4bc09b6222500c2f0fc32e85567d285ef53bce06"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 1: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_crypto-gotip-linux-amd64 has failed with summary (view all results):

---

FAILURE

• go on master (commit ba9c445)
• crypto on master (change 472695)

Error: failed to run "test golang.org/x/crypto module": exit status 1

Links:

• "test golang.org/x/crypto module" (combined output)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/472695. After addressing review feedback, remember to publish your drafts!