crypto
crypto copied to clipboard
ed25519: update godoc for consts in crypto/ed25519
This is a follow-up to CL 317169, which dropped compatibility with go1.12, and made this package an alias / wrapper for crypto/ed25519 in stdlib.
This patch updates their godoc to include a docs-link to the equivalent consts in stdlib.
This PR (HEAD: 070f3a658bdd92974ba315321c18a4198ba9593d) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/448237 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Filippo Valsorda:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Michael Knyszek:
Patch Set 1: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Filippo Valsorda:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Michael Knyszek:
Patch Set 1: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: b307d43f3838f2376e16c24d478ea85df9568dba) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/448237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from t hepudds:
Patch Set 2: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from t hepudds:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from t hepudds:
Patch Set 2: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from t hepudds:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!
Message from Sebastiaan van Stijn:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448237. After addressing review feedback, remember to publish your drafts!