crypto icon indicating copy to clipboard operation
crypto copied to clipboard

ssh: implement partial success in server

Open peterverraedt opened this issue 3 years ago • 3 comments

Add support for sending back partial success to the client while handling authentication in the server. This is implemented by a special error that can be returned by any of the authentication methods, which contains the authentication methods to offer next. This way a server can be implemented that e.g. only accepts public keys for the initial authentication, and only after partial success presents a keyboard interactive authentication method.

Signed-off-by: Peter Verraedt [email protected]

peterverraedt avatar Apr 08 '22 15:04 peterverraedt

This PR (HEAD: dccdcf877ea84d40e63726ddf39a569096c20cca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/399075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 08 '22 15:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/399075. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 08 '22 15:04 gopherbot

Hi,

I sent a similar patch here. I think we need to wrote a proposal for the API change before a patch can be accepted

drakkan avatar Apr 09 '22 08:04 drakkan