crypto icon indicating copy to clipboard operation
crypto copied to clipboard

Published 20 hours ago • verified publisher icon golang

ssh: add support for extension negotiation (rfc 8308)

Open drakkan opened this issue 3 years ago • 24 comments

This is a rebase of the following PR

https://github.com/golang/crypto/pull/197

with some changes and improvements:

  • added support for client certificate authentication
  • removed read loop from server handshake
  • adapted extInfoMsg to upstream changes

Signed-off-by: Nicola Murino [email protected]

drakkan avatar Mar 30 '22 10:03 drakkan

This PR (HEAD: 7fe3443040f2a633741b8ea76a8d0205c88cadaa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 30 '22 10:03 gopherbot

This PR (HEAD: 0196e38d30c462b7e1eab4a786363939a39fb4c7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 30 '22 11:03 gopherbot

This PR (HEAD: 2b413598b393b29479f367197daae83c8eb42907) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 30 '22 14:03 gopherbot

This PR (HEAD: 4929d4a7625667bfd8bc8b92a6ca2bbfdc7b70b0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 30 '22 15:03 gopherbot

This PR (HEAD: 76c940069807150cbdc239f40f72f84deb3eb21c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 30 '22 15:03 gopherbot

This PR (HEAD: 5835f04acddd50f994fe0ac81f9a4024e743b59a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 31 '22 09:03 gopherbot

Message from Nicola Murino:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 31 '22 09:03 gopherbot

Message from Stan Hu:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 18 '22 18:05 gopherbot

Message from Stan Hu:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 18 '22 18:05 gopherbot

This PR (HEAD: 92ea34e7eab8f96a776aba5e50761e82a8fd42f7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 19 '22 15:05 gopherbot

Message from Nicola Murino:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 19 '22 15:05 gopherbot

Message from Stan Hu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 14 '22 23:06 gopherbot

Message from Stan Hu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 15 '22 04:06 gopherbot

This PR (HEAD: 8cff98973996ea82734de3db273cf47ae2b2e3bf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/396714 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jun 15 '22 08:06 gopherbot

Message from Nicola Murino:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 15 '22 08:06 gopherbot

Message from Stan Hu:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 15 '22 19:06 gopherbot

Hello, is there any ETA on when this PR will merge? Thanks.

r0mant avatar Aug 02 '22 20:08 r0mant

@r0mant Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. Thanks.

ianlancetaylor avatar Aug 03 '22 00:08 ianlancetaylor

Message from Michał Trojnara:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 13 '22 17:09 gopherbot

Message from Nicola Murino:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 14 '22 14:09 gopherbot

Message from Michał Trojnara:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 14 '22 15:09 gopherbot

Message from Nicola Murino:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 14 '22 16:09 gopherbot

Message from Filippo Valsorda:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 15 '22 11:09 gopherbot

Message from Nicola Murino:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 15 '22 17:09 gopherbot

Message from Filippo Valsorda:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396714. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 03 '22 18:11 gopherbot

@drakkan Did this get addressed upstream?

reedloden avatar Jan 23 '23 18:01 reedloden

@reedloden doesn't seem like it was.

brodock avatar Mar 01 '23 14:03 brodock

Actually, it did. https://go.dev/cl/447757 was merged in November 2022 and pared down this pull request: https://github.com/golang/go/issues/49269#issuecomment-1302661997.

I don't think we need to support ext-info-s either since this causes the client to send SSH_MSG_EXT_INFO, and this pull request just read and threw away the message.

stanhu avatar May 03 '23 21:05 stanhu