crypto
crypto copied to clipboard
golang
ssh: add openssh controlmaster socket support
ssh: add openssh controlmaster socket support
Adds support for establishing SSH sessions over an existing "ControlMaster" [unix domain] socket in proxy mode.
Details of the protocol can be found here: https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.mux More details about ControlMaster sockets can be found here: https://linux.die.net/man/5/ssh_config
Note that proxy mode is a relatively new feature of OpenSSH. If you are using an older version you will likely receive "unsupported request" during the handshake. I have successfully tested with OpenSSH_7.4p1.
https://github.com/golang/go/issues/31874 https://github.com/golang/go/issues/32958
This PR (HEAD: a6941cd1c4e3c4a5b81894340b80e43ff66fb10a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/383374 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Han-Wen Nienhuys:
Patch Set 1:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/383374. After addressing review feedback, remember to publish your drafts!
Message from Han-Wen Nienhuys:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/383374. After addressing review feedback, remember to publish your drafts!
Hi @y3llowcake!
Thanks for this, I've been wanting to support ControlMaster sockets in my ssh client. I've tested this pr on top of x/crypto master and it seems to work just fine. What's needed to get this merged?
I am not super familiar with the people and process for this project. The reviewer that was assigned to the PR hasn't commented, and there hasn't been much instruction on the issue thread, so it's unclear to me what the next steps are. I'll ping the issue thread again today, I suspect that's the best place to follow along and discuss: https://github.com/golang/go/issues/32958
Message from Damien Neil:
Patch Set 1:
(11 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/383374. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 1:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/383374. After addressing review feedback, remember to publish your drafts!