crypto icon indicating copy to clipboard operation
crypto copied to clipboard

x/crypto/blake2s: Allow computing variable-length digests.

Open Nephirus opened this issue 5 years ago • 3 comments

Current implementation provides only XOF-based method for digest size other than 16 or 32 bytes. This commit allows digest size between 1 and 32 bytes, as defined by the BLAKE2s paper.

Fixes #36429

Signed-off-by: Jiří Keresteš [email protected]

Nephirus avatar Jul 08 '20 08:07 Nephirus

This PR (HEAD: c3aac1c4bcb89293d33a2d998a3ff7ec9bddbc62) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/241437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 08 '20 09:07 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/241437. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 08 '20 09:07 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/241437. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot