crypto icon indicating copy to clipboard operation
crypto copied to clipboard

acme: add support for external account bindings

Open munnerz opened this issue 6 years ago • 7 comments

This adds support for ExternalAccountBindings into the crypto/acme client.

It is based on section 7.3.4 of RFC8555: https://tools.ietf.org/html/rfc8555#section-7.3.4

I have tested this against Pebble with support for EABs https://github.com/letsencrypt/pebble/pull/288 as well as another CAs ACME implementation that requires EAB.

/cc @JoshVanL

munnerz avatar Dec 03 '19 18:12 munnerz

This PR (HEAD: b4174033096fcbda90df3250d9507324ea2b7dcf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Dec 03 '19 19:12 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/209678. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 03 '19 19:12 gopherbot

This PR (HEAD: 79ac0b8fdc77409295e21ef1a03e306d49c05780) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Dec 03 '19 20:12 gopherbot

This PR (HEAD: e1844778daa5d2f4a29019db1e7faa36596a6d27) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Dec 03 '19 20:12 gopherbot

This PR (HEAD: f3a5c70aa159893665d2f6c932ef9d135944a62c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/209678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 11 '20 07:05 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/209678. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot

Hi munnerz@, I saw your work here and was interested in getting it pushed through. I realized that it needed an API proposal before it would be considered for review. I made the proposal at golang/go#41430 which was accepted with minor modifications. I built upon your work and sent out #162, but it looks like the googlebot wants an additional consent.

Would you mind adding a @googlebot I consent. comment to PR #162?

Thanks for all of the work that you put in on this project!

jdkasten avatar Oct 20 '20 16:10 jdkasten