blog icon indicating copy to clipboard operation
blog copied to clipboard

content: fix typo in concurrency-timeouts.article

Open szzhiyang opened this issue 5 years ago • 8 comments

szzhiyang avatar Mar 29 '20 10:03 szzhiyang

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 29 '20 10:03 googlebot

@googlebot I signed it!

szzhiyang avatar Mar 29 '20 10:03 szzhiyang

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 29 '20 10:03 googlebot

This PR (HEAD: 85bc74bfc410bdb77e800c2a54838eaae98de520) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/blog/+/226207 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 29 '20 10:03 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/226207. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 29 '20 10:03 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

The intent is to backquote time.After. I think the right thing to do here is to move the backquotes inside the [], so that we get [time.After]. Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/226207. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 29 '20 16:03 gopherbot

Message from Andrew Gerrand:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/226207. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 09 '20 05:07 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/226207. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot

This PR is being closed because golang.org/cl/226207 has been abandoned.

Closing because the content of x/blog moved to x/website (see CL 324270). If this change still applies, it'd need to be re-sent it to x/website. Thanks.

gopherbot avatar Mar 03 '23 00:03 gopherbot