arch
arch copied to clipboard
golang
x86spec: fix header parsing
The existing implementation of the Intel x86 doc parser matches headers by just trimming spaces. However, there are cases, when a header string takes several lines, which breaks current switch case matching, e.g. during the parsing of AMX operations. This commit fixes it by replacing \n with a whitespace in a header string.
For: golang/go#61079
This PR (HEAD: 0d9feca4d2a6bc407ccd629fdc26ecd7e82f3b84) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 1f785a733bc626423f6580ec10010a986adfe68f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Anton Kuklin:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 2: Run-TryBot+1
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: e97199fb97d02cafe8d3c92f1d6f680327b674ca) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 08f90141249018a52b96489cfc80107b99197878) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Anton Kuklin:
Patch Set 4:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Anton Kuklin:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 2: Run-TryBot+1
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!
Message from Anton Kuklin:
Patch Set 4:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. After addressing review feedback, remember to publish your drafts!