arch
arch copied to clipboard
golang
x86: allow decoding of AVX instructions
Fixes golang/go#48584 golang/go#41043 golang/go#69792
This PR extends the decoder in x86asm to deal with VEX-encoded instructions, the way I went about this was to extend the table built by x86map - this ultimately required updating the x86.csv - I combined it with the x86.v0.2.csv and took the VEX definitions from there, as they included the [xy]mmV references that were necessary to decode all the registers.
Now I have to admit that I know quite little about x86 instructions, so it's very possible I missed quite a lot of stuff, but combining the new code with how it was dealing with REX instructions went pretty well and as far as the tests can say, this is now able to decode VEX-prefixed instructions.
Any feedback would be appreciated.
This PR (HEAD: fa2736fd729a97c762b0d834194011d12e36973c) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!
Message from Michal Hruby:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 120984025ba02c405f54864a0bcde93203adb43b) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 4a7d831a847ed00a6fca53a2ed51cb55571299d6) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Cherry Mui:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!
Message from Michal Hruby:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: b17390372d213617393c064030168246d86bf225) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/618036.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Michal Hruby:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!
Message from Michal Hruby:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/618036. After addressing review feedback, remember to publish your drafts!