migrate icon indicating copy to clipboard operation
migrate copied to clipboard

Implement WithConnection for sqlserver database driver

Open selaux opened this issue 3 years ago • 1 comments

Similar methods have already been implemented for the mysql and postgres database. This adds WithConnection(ctx context.Context, conn *sql.Conn, config *Config) (*SQLServer, error) to the SQL Server database driver as well.

Issues/PRs for this can be found here:

  • Issue: https://github.com/golang-migrate/migrate/issues/578
  • PR for MySQL: https://github.com/golang-migrate/migrate/pull/583
  • PR for Postgresql: https://github.com/golang-migrate/migrate/pull/659

I tried to align as close as possible to the other implementations.

Note: The linter errors dont seem to be related to the contents of this PR.

selaux avatar Aug 16 '22 11:08 selaux

Coverage Status

Coverage increased (+0.03%) to 57.804% when pulling a5148efe1045f95606d67a85725a40f36f4473e0 on selaux:implement-with-connection-for-sql-server into 03613f14ac4f975eb0070a23958123c5d84e6b87 on golang-migrate:master.

coveralls avatar Aug 16 '22 11:08 coveralls