migrate icon indicating copy to clipboard operation
migrate copied to clipboard

Snowflake - Tests, Role, Warehouse and Multi-Statement

Open ninthclowd opened this issue 3 years ago • 4 comments
trafficstars

Hello, as I mentioned in #404, I need this functionality for a project I am working on. This program is great; I really like the design.

This PR adds the following:

  • Test coverage for snowflake using a SQL mock library, since it is not possible to run snowflake in a local container
  • The ability to specify connection role through the x-role parameter
  • The ability to specify connection warehouse through the x-warehouse parameter
  • The ability to specify multi-statement support through the x-multi-statement parameter, which enables snowflake's built in multi-statement support
  • Removes pq.* module references, since the pq library is not referenced by the gosnowflake library

I understand there are some older PRs out there that do similar functionality, so I understand if you would prefer to continue to see those through to the end and don't want to accept this PR. I'm only submitting it in the case that those contributors are no longer available, or if you would prefer the new functionality be covered by tests.

Thanks!

Addresses #543, #431 and #404

ninthclowd avatar Aug 04 '22 15:08 ninthclowd

Coverage Status

Coverage increased (+1.0%) to 58.772% when pulling 0632654415c97cd03d2a40d65d82f5fc464746b9 on ninthclowd:master into 03613f14ac4f975eb0070a23958123c5d84e6b87 on golang-migrate:master.

coveralls avatar Aug 04 '22 15:08 coveralls

Looks like some of the tests timed out that aren't related to the commit I added - possibly a transient docker issue: dktest.go:176: Failed: error pulling image: cassandra:3.11 error: Error response from daemon: Get "https://registry-1.docker.io/v2/library/cassandra/manifests/sha256:3e2b5b7448b073fa1e1f65ade47fa4b92cf1490d3a28b0cfe3d95a4b04c96bd0": EOF

I cannot see a way to rerun the workflow manually without posting a commit, is it possible to do that?

ninthclowd avatar Aug 08 '22 14:08 ninthclowd

Nevermind - I found that I can just force push an empty amend. Fingers crossed it all passes this time :)

ninthclowd avatar Aug 08 '22 15:08 ninthclowd

Looks like the workflow was now failing because some other existing files not related to the snowflake update were not formatted. Pushed d318874 to fix.

ninthclowd avatar Aug 08 '22 18:08 ninthclowd

Closing this PR - will reopen from a different source branch

ninthclowd avatar Aug 15 '22 21:08 ninthclowd