recipes icon indicating copy to clipboard operation
recipes copied to clipboard

♻️ Refactor(v3): Update SSE recipe to use Buffered Streaming

Open grivera64 opened this issue 11 months ago • 3 comments

Is your feature request related to a problem?

This issue is related to the recently merged PR for fiber/v3 the main repo: fiber#3131.

This issue proposes to update the SSE recipe to take advantage of this new v3 feature.

Describe the solution you'd like

This issue is to track updating the call c.Status(fiber.StatusOK).Context().SetBodyStreamWriter(fasthttp.StreamWriter(...)) to instead use c.Status(fiber.StatusOK).SendStreamWriter(...).

We should also update the markdown tutorial as well for SSE.

Describe alternatives you've considered

N/A

Additional context

This update is from a v2->v3 change. It may be a good idea to use a separate migration branch for this change to later merge into master when v3 is officially released.

grivera64 avatar Nov 27 '24 18:11 grivera64

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

welcome[bot] avatar Nov 27 '24 18:11 welcome[bot]

I was thinking, should we make a main branch to house all v2->v3 updates (e.g. v3-migration)? This way, we can contain all v3 updates into one simple merge once v3 is officially released.

If not, I can add this make a PR to a separate branch (e.g. v3-migration/sse-using-buffered-streams) and we can merge it directly into master once v3 is released.

grivera64 avatar Dec 04 '24 07:12 grivera64

@grivera64 Let me cleanup the readmes/go.mods first. Then we could prob do that

gaby avatar Dec 04 '24 13:12 gaby

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 08:07 stale[bot]