godot icon indicating copy to clipboard operation
godot copied to clipboard

Editor docs not scrolling to correct position on search or ctrl+click of a term

Open donn-xx opened this issue 1 year ago • 10 comments
trafficstars

Tested versions

Noticed this since early 4.x. Still happening in latest 4.4 dev.

System information

Godot v4.4.dev (61598c5c8) - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (nvidia; 535.183.01) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)

Issue description

When you ctrl+click a function in gdscript, the docs open but the help text is at the wrong position. Meaning, the function is often not even on the screen of text you get and you have to scroll or Ctrl+F to locate it.

The same happens when one searches using F1 (or Alt+F1).

This does not happen all the time. It's hard to pin down.

Steps to reproduce

Just play with help and watch.

Minimal reproduction project (MRP)

None

donn-xx avatar Sep 03 '24 08:09 donn-xx

I’m also annoyed by this bug regularly. What does seem to help is going back to the original script and ctrl clicking the variable or method again, after which it will always scroll to the right position. So perhaps this has something to do with the script not being open yet.

AdriaandeJongh avatar Sep 03 '24 11:09 AdriaandeJongh

  • looks like a duplicate of https://github.com/godotengine/godot/issues/96448

kitbdev avatar Sep 04 '24 19:09 kitbdev

That report seems to be related to a fix introduced between 4.2 and 4.3. I've experienced the bug described in this report throughout 4.2.

AdriaandeJongh avatar Sep 05 '24 08:09 AdriaandeJongh

There were multiple issues regarding scrolling and navigation in the past. After https://github.com/godotengine/godot/pull/96449, everything should be fine though. If you like you can test the PR and report back. I did quite some testing and scrolling was working perfectly everytime.

Maran23 avatar Sep 05 '24 12:09 Maran23

ETA: Might not have got the right code. I just pulled from main and compiled.

Just compiled from main. Opened a project, ctrl+clicked intersect_ray and it's a few lines into the func: It's off by several lines

Going back to the code, and doing it again gets it right.

I wonder if this isn't a font/line-spacing/linuxy kind of problem?

donn-xx avatar Sep 07 '24 05:09 donn-xx

No it was just wrong code in Godot that is fixed in https://github.com/godotengine/godot/pull/96449.

Maran23 avatar Sep 07 '24 09:09 Maran23

I see it's pending a review. Thanks for the fix and I'll keep en eye out to test it.

donn-xx avatar Sep 08 '24 08:09 donn-xx

If folks from here can download the PR build artifacts and test that this fixes it w/o regressions, it's simple enough that it's likely to get merged soon! I can't replicate it or I'd test it myself!

anvilfolk avatar Sep 27 '24 18:09 anvilfolk

Am on v4.3.stable.official [77dcf97d8] and it's working well again. I even forgot about this issue!

donn-xx avatar Sep 28 '24 11:09 donn-xx

For anyone who wants to test this, rebased the branch to master, you can download it here under Artifacts: https://github.com/godotengine/godot/pull/96449/checks

Maran23 avatar Oct 18 '24 19:10 Maran23