godot icon indicating copy to clipboard operation
godot copied to clipboard

Update etcpak to 2.0

Open BlueCube3310 opened this issue 1 year ago • 4 comments
trafficstars

Depends on #89567

Updates etcpak to 2.0, the latest official version. Said version also includes bc7enc as a dependency (though not used by Godot's importer), should it be removed with a Godot-specific patch?

BlueCube3310 avatar Aug 15 '24 12:08 BlueCube3310

It makes sense to add a readme addition to remove bc7enc

fire avatar Aug 15 '24 13:08 fire

It looks like all this does is remove CompressEtc1Alpha and CompressEtc2Alpha and adds CompressBc7. But I guess it would be nice to be back on an official release.

Is there any value in us using the BC7 compression here? Or do we use a different/better library already?

clayjohn avatar Aug 16 '24 19:08 clayjohn

The BC7 compression is much faster than CVTT (what Godot uses currently), although the quality is generally lower (only 4 block modes are available) and most of the performance improvements require SSE4/AVX2.

BlueCube3310 avatar Aug 16 '24 20:08 BlueCube3310

The BC7 compression is much faster than CVTT (what Godot uses currently), although the quality is generally lower (only 4 block modes are available) and most of the performance improvements require SSE4/AVX2.

Ah, so probably not worth integrating yet. I would do a Godot-specific patch to remove it just due to the size

clayjohn avatar Aug 16 '24 21:08 clayjohn

I'm closing this for now as the upstream changes aren't significant to Godot's implementation, plus now it requires a patch.

BlueCube3310 avatar Oct 30 '24 10:10 BlueCube3310