godot icon indicating copy to clipboard operation
godot copied to clipboard

Remove duplicate `ARRAY_CUSTOM_RGBA8_UNORM` ref in Mesh docs

Open flooxo opened this issue 1 year ago • 2 comments
trafficstars

This PR closes https://github.com/godotengine/godot-docs/issues/8901

Removes duplicate reference of ARRAY_CUSTOM_RGBA8_UNORM

flooxo avatar Feb 05 '24 13:02 flooxo

Looking at some of the code I think this should be ARRAY_CUSTOM_RGBA8_SNORM instead

CC @clayjohn

Not sure if this is the code for this but this seems relevant: https://github.com/godotengine/godot/blob/b4e2a24c1f62088b3f7ce0197afc90832fc25009/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp#L1298

AThousandShips avatar Feb 05 '24 13:02 AThousandShips

Looking at some of the code I think this should be ARRAY_CUSTOM_RGBA8_SNORM instead

Indeed, ArrayCustomFormat's docs already say it's one of the encoded as PackedByteArray formats: https://github.com/godotengine/godot/blob/36e943b6b20cb7a8a89bc30489c4a81c3e149d74/doc/classes/Mesh.xml#L264-L290

kleonc avatar Feb 08 '24 00:02 kleonc

Please edit your commit message to remove unnecessary messages from commits, should just say:

Remove duplicate reference of CUSTOM_ARRAY_RBGA8_URNOM in docs

AThousandShips avatar Feb 21 '24 08:02 AThousandShips

Thanks! And congrats for your first merged Godot contribution :tada:

akien-mga avatar Feb 27 '24 09:02 akien-mga

Cherry-picked for 4.2.2. Cherry-picked for 4.1.4.

akien-mga avatar Mar 11 '24 14:03 akien-mga