godot
godot copied to clipboard
Add gate sound effect
Gate seemed like it was one of the effects obviously missing from the sfx that come with Godot, so I made a very basic one with only a threshold parameter.
This will hopefully have an attack/hold/release envelope.
- Production edit: This closes https://github.com/godotengine/godot-proposals/issues/8426.
@YuriSizov what are the review rules for the less active Godot Engine teams?
i got confused and made a state diagram,,,
The extra parameters seem to work completely fine now, freezing commits here unless there are any more review changes or system-specific issues that my computer isn't running into
Please merge into one commit as we review. Note that it'll require manual approval of cicd for first time contributors.
not sure how to rebase on the gate-sound-effect-rebase branch, i've just been making a new branch every time (using commandline git)
See this documentation, if you need help with squashing.
Any updates on when this will be merged?
Any updates on when this will be merged?
This is good on my end, but commits need to be squashed together into a single commit before this can be merged.
Got it