godot icon indicating copy to clipboard operation
godot copied to clipboard

Add gate sound effect

Open marc-weber1 opened this issue 1 year ago • 8 comments
trafficstars

Gate seemed like it was one of the effects obviously missing from the sfx that come with Godot, so I made a very basic one with only a threshold parameter.

This will hopefully have an attack/hold/release envelope.

  • Production edit: This closes https://github.com/godotengine/godot-proposals/issues/8426.

marc-weber1 avatar Dec 13 '23 04:12 marc-weber1

Gate Test Project.zip

my test example if it saves anyone time

marc-weber1 avatar Dec 13 '23 08:12 marc-weber1

@YuriSizov what are the review rules for the less active Godot Engine teams?

fire avatar Dec 14 '23 18:12 fire

image i got confused and made a state diagram,,,

marc-weber1 avatar Dec 18 '23 10:12 marc-weber1

The extra parameters seem to work completely fine now, freezing commits here unless there are any more review changes or system-specific issues that my computer isn't running into

marc-weber1 avatar Dec 18 '23 20:12 marc-weber1

Please merge into one commit as we review. Note that it'll require manual approval of cicd for first time contributors.

fire avatar Dec 18 '23 21:12 fire

not sure how to rebase on the gate-sound-effect-rebase branch, i've just been making a new branch every time (using commandline git)

marc-weber1 avatar Dec 20 '23 02:12 marc-weber1

See this documentation, if you need help with squashing.

YuriSizov avatar Dec 20 '23 11:12 YuriSizov

Any updates on when this will be merged?

ThomasUijlen avatar Apr 29 '25 08:04 ThomasUijlen

Any updates on when this will be merged?

This is good on my end, but commits need to be squashed together into a single commit before this can be merged.

Calinou avatar Apr 29 '25 16:04 Calinou

Got it

marc-weber1 avatar May 02 '25 00:05 marc-weber1