godot icon indicating copy to clipboard operation
godot copied to clipboard

Conversion Tool: MacOS Export Template Settings Missing

Open keithrdavis opened this issue 2 years ago • 9 comments

Godot version

4.0

System information

MacOS 13.2.1/M2

Issue description

After running a v3.5.1 project with MacOS, Windows, and Linux export settings (templates) through the v4.0 conversion tool, only the Windows and Linux export settings remain. The MacOS settings are missing.

Steps to reproduce

Run a v3.5.1 project with a MacOS export template through the v4.0 conversion tool.

Minimal reproduction project

N/A

keithrdavis avatar Mar 09 '23 14:03 keithrdavis

MRP attached...

ConversionToolBugs.zip

keithrdavis avatar Mar 09 '23 15:03 keithrdavis

Can confirm that no export template for MacOS is available after conversion, it seems the platform has changed from "Mac OS" to "macOS", will take a look

AThousandShips avatar Mar 09 '23 15:03 AThousandShips

Thank you!

keithrdavis avatar Mar 09 '23 15:03 keithrdavis

The converter doesn't touch the export at all at present it looks like

AThousandShips avatar Mar 09 '23 15:03 AThousandShips

I wonder why the editor doesn't pick it up... I looked at the export_presets.cfg and the Mac export is there...

keithrdavis avatar Mar 09 '23 16:03 keithrdavis

Because it is named differently, the platform name isn't the same in 3.x and 4.0 for some reason.

AThousandShips avatar Mar 09 '23 16:03 AThousandShips

Thank you!

keithrdavis avatar Mar 09 '23 16:03 keithrdavis

It was changed here: #40961 Which implemented: https://github.com/godotengine/godot-proposals/issues/1161

AThousandShips avatar Mar 09 '23 16:03 AThousandShips

So far we haven't really considered the export_presets.cfg to be in scope for what the converter would do. A lot of the export settings have changed, and this would require a significant amount of work/code to do a clean conversion, while it's fairly easy to redo the config manually in the editor after converting the project.

It could still be done technically of course, but we'll have to see if the gain is worth the added code to maintain.

akien-mga avatar Mar 09 '23 16:03 akien-mga