godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

allow disabling 2d from editor features, change default plugin to 2d

Open nathanfranke opened this issue 5 years ago • 9 comments

~~Depends on: https://github.com/godotengine/godot/pull/61435, https://github.com/godotengine/godot/pull/61434~~

Resolves: https://github.com/godotengine/godot-proposals/issues/1352

Follow-up to #41036

This PR allows disabling the 2D editor in the editor features dialog. Also improves the main screen plugin code by allowing no plugins to be loaded at a time.

How the editor looks without any main screen plugins (Pointless, but still possible): Screenshot of Godot Editor. There are no plugin icons on the top bar, and the middle screen is empty.

nathanfranke avatar Aug 05 '20 06:08 nathanfranke

Feels a bit wrong to have ability to disable 2D in the editor while we don't have scons disable_2d=yes yet. 😛

But this is just me venting, ignore. 🙂

Xrayez avatar Aug 05 '20 10:08 Xrayez

I don't really see the point. This feature selection is meant to simplify the interface, not really to disallow you completely from making a game.

Feels a bit wrong to have ability to disable 2D in the editor while we don't have scons disable_2d=yes yet. stuck_out_tongue

I don't think this will ever happen, while there are a lot of games without 3D needs, all 3D ones need 2D. 2D is needed for interfaces, but could also be needed in embedded viewports. I don't see any situation where you would need to disable 2D in a game.

groud avatar Aug 05 '20 13:08 groud

Yeah I thought the same about UI stuff, but according to quote unquote "beginners nodes dock" (godotengine/godot-proposals#1206), this could be treated separately from 2D stuff. I mean, yeah UI is certainly 2D (in 2020) but the purpose is agnostic to dimensions (they do inherit from canvas item though...)

Xrayez avatar Aug 05 '20 13:08 Xrayez

This PR, and the ability to disable 2D in scons, are completely separate problems. See https://github.com/godotengine/godot-proposals/issues/190#issuecomment-552125902

aaronfranke avatar Aug 05 '20 17:08 aaronfranke

After looking at https://github.com/godotengine/godot-proposals/issues/190, it would be nice to eventually separate 2D and GUI to different plugins. IMO 2D and GUI should never really interact directly and it can cause confusion and annoyance.

nathanfranke avatar Aug 05 '20 21:08 nathanfranke

@nathanfranke https://github.com/godotengine/godot/pull/61435 is merged, so it can marked as such in first comment.

Anutrix avatar Jun 26 '22 06:06 Anutrix

This is being force pushed for a couple months now... is it going to get in by 4.0?

Zireael07 avatar Sep 16 '22 07:09 Zireael07

This is being force pushed for a couple months now... is it going to get in by 4.0?

Probably, but only if I can figure out the memory leak. All the stack traces are going outside of the scope of the PR. :cry:

nathanfranke avatar Sep 16 '22 15:09 nathanfranke

This is being force pushed for a couple months now... is it going to get in by 4.0?

There hasn't been any discussion about it lately. I guess we'll have to revisit it once it's not longer a draft.

Edit: Though it seems that reduz has left a comment that this should probably be rejected, because he believes this PR has been made obsolete by the new build profiles feature.

YuriSizov avatar Sep 16 '22 17:09 YuriSizov

Thanks for the enthusiasm! I reverted the default plugin change in my staging branch (tes if anyone's curious), and I am currently working on fixing that memory leak.

nathanfranke avatar Oct 04 '22 21:10 nathanfranke