godot-team-reports
godot-team-reports copied to clipboard
godotengine
Add grouping/filtering by PR meeting/high priority labels
Discussed on rocketchat about the review meeting virtual team and high priority virtual team.
I've been thinking about it a bit... We don't use high priority for PRs, only for issues (and this page doesn't track issues so far). That leaves "for pr meeting". Now, I could add it as a "team", but it doesn't provide much benefit over just opening a search like https://github.com/godotengine/godot/pulls?q=is%3Apr++is%3Aopen+label%3A%22for+pr+meeting%22+.
What could be useful, is adding a filter "for PR meeting" that would only show PRs with that label assigned to each team/reviewer. What do you think?
What's the best way to show experimental features so I can try them? I don't know.
I'm afraid we don't have much in terms of different dev/staging/production environments 🙃 We should start from the problem that we are trying to solve. Given only one of the proposed labels is actually useful, what would be the use-case for it? Simply listing all the PR meeting tasks can be done with the link that I've provided above. Do we need more in-depth information that the team reports page gives, like how long it has been open and other details?
What I'm thinking here, is that having "marked for PR meeting" as a generic filter can help each team open their list and see if they have any PRs that are marked. Having all of those PRs in a single united list is less useful for individual teams, or individual reviewers.
The problem:
Given
What are the github pull requests I can focus attention upon for maximum impact and least effort?
Make the page show this for me.
Another related problem is what pull requests require pending work from Godot Engine organization / maintainers so they can be unblocked.
Sorry about the reposting. Wanted to separate the logical ideas.
For example the current team page scene seems to be aiming for the least amount of impact.
I changed some defaults and these pull requests do match what I think is important, and with recency.
