godot-docs icon indicating copy to clipboard operation
godot-docs copied to clipboard

Highlights make reading difficult.

Open setanarut opened this issue 3 years ago • 6 comments

Your Godot version: Godot 3 alpha 3

Issue description: Highlights make reading difficult and there is no easy way to turn off highlights when using the search bar. (Except manually deleting the URL). I have to change this address every time. Ekran Resmi 2022-03-07 20 30 36

URL to the documentation page: https://docs.godotengine.org/en/latest/classes/class_string.html?highlight=String Ekran Resmi 2022-03-07 20 15 44

It is very pointless that the search highlighting is still stuck on the redirected page. All browsers already have a search feature. It's ridiculous to impose that.

setanarut avatar Mar 07 '22 17:03 setanarut

I also find these highlights bothersome. We could tweak the CSS to make them less prominent, or see if they can be outright disabled.

I also always need to edit the URL manually whenever I use the search to find a page that I want to link to users on another platform. Overall, I'd be fine if we found a way to fully disable the ?highlight= part added by the search component.

akien-mga avatar Mar 09 '22 10:03 akien-mga

I haven't found a way to fully disable the ?highlight= part, but we can remove it from the URL via JavaScript and make the highlight invisible via CSS.

Calinou avatar Mar 09 '22 14:03 Calinou

Hey there! I would like to try an tackle this issue. Should these changes be made within the _static/css/custom.css and _static/cs/custom.js files, or is there a better place to make the changes? Thanks!

eruhlinteractive avatar May 01 '22 18:05 eruhlinteractive

Hey there! I would like to try an tackle this issue. Should these changes be made within the _static/css/custom.css and _static/cs/custom.js files, or is there a better place to make the changes? Thanks!

You'll proably need to modify both CSS and JavaScript to ensure that 1) no temporary highlight flash appears, 2) the &highlight= part of the URL is removed.

Calinou avatar May 01 '22 19:05 Calinou

For removing the ?highlight=* portion of the URL: would it be best to redirect the user to the same page without the highlight tag, or simply try to replace it without needing to reload the page?

eruhlinteractive avatar May 01 '22 21:05 eruhlinteractive

For removing the ?highlight=* portion of the URL: would it be best to redirect the user to the same page without the highlight tag, or simply try to replace it without needing to reload the page?

I'd prefer removing the &highlight=* portion of the URL without reloading the page. Otherwise, navigation would be slowed down after clicking on a search result.

Calinou avatar May 02 '22 12:05 Calinou