godot-demo-projects icon indicating copy to clipboard operation
godot-demo-projects copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Porting material testers project to Godot 4

Open BastiaanOlij opened this issue 4 years ago • 9 comments

Converting this to Godot 4 because we need this for testing the new renderer.

image

Note, currently two godot balls with broken materials that cause issues, see #50186 for a fix.

BastiaanOlij avatar May 10 '21 04:05 BastiaanOlij

@BastiaanOlij Soon we will begin porting the demos to the current Godot master branch in preparation for Godot 4 alpha (and therefore this PR wouldn't violate the first rule anymore :wink:). Can you update this PR so that it works with the current master branch of Godot, and check if there is anything that needs doing before merging? The CI checks have failed.

aaronfranke avatar Jun 10 '21 01:06 aaronfranke

@BastiaanOlij Soon we will begin porting the demos to the current Godot master branch in preparation for Godot 4 alpha (and therefore this PR wouldn't violate the first rule anymore 😉). Can you update this PR so that it works with the current master branch of Godot, and check if there is anything that needs doing before merging? The CI checks have failed.

I've brought it up to todays master, but it still fails when I unhide the meshes with a material that use SSR.

BastiaanOlij avatar Jun 14 '21 04:06 BastiaanOlij

This PR fixes the Godot Balls that were hidden: https://github.com/godotengine/godot/pull/50186 I'll unhide them on the assumption that this PR will be merged today.

BastiaanOlij avatar Jul 06 '21 00:07 BastiaanOlij

@aaronfranke you're changes should be in, I did keep the static types for nodes.

BastiaanOlij avatar Jul 06 '21 00:07 BastiaanOlij

I've added two reflection probes around the mirror ball to test reflections. There are still issues to be solved here

BastiaanOlij avatar Jul 06 '21 00:07 BastiaanOlij

Note that https://github.com/godotengine/godot/pull/50196 adds logic that allows a single reflection probe to do a decent job in this use case.

BastiaanOlij avatar Jul 06 '21 14:07 BastiaanOlij

@BastiaanOlij Can you rebase this PR and ensure it works on the latest master branch of Godot?

aaronfranke avatar Mar 26 '22 10:03 aaronfranke

Owh dang, the import files have changed for the new godot 3 version, thats gonne be fun :) I'll have a look

BastiaanOlij avatar Mar 28 '22 08:03 BastiaanOlij

Ok, that was a bit of a nightmarish rebase, it looks like everything works again but hopefully nothing went missing.

BastiaanOlij avatar Mar 28 '22 10:03 BastiaanOlij

After #823, what parts of this are remaining or needed?

Anutrix avatar Apr 16 '23 19:04 Anutrix

https://github.com/godotengine/godot-demo-projects/pull/823 fully supersedes this PR, closing. Thanks for the contribution nonetheless!

Calinou avatar Apr 16 '23 22:04 Calinou