godot-cpp icon indicating copy to clipboard operation
godot-cpp copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Fix binding generation command in CMake to escape path strings if necessary

Open PierceLBrooks opened this issue 3 years ago • 3 comments

These changes resolve the issue that I filed here: https://github.com/godotengine/godot-cpp/issues/865

PierceLBrooks avatar Sep 24 '22 04:09 PierceLBrooks

Is the change no longer required?

Calinou avatar Apr 01 '23 23:04 Calinou

@Calinou

Is the change no longer required?

My mistake, as I was closing out some other obsolete pull requests of mine this was overzealously included. I will reopen it now. Most cases will nonetheless work fine without the double quotes around the path parameter, but I still cannot guarantee success on all platforms where the corresponding string value contains space characters.

PierceLBrooks avatar Apr 02 '23 00:04 PierceLBrooks

I have resolved the merge conflict which emerged recently.

PierceLBrooks avatar Apr 02 '23 20:04 PierceLBrooks