godot-cpp icon indicating copy to clipboard operation
godot-cpp copied to clipboard

the CMakeLists makes it so godot-cpp's output static lib is placed in the wrong directory

Open SeleDreams opened this issue 4 years ago • 1 comments

I think godot-cpp has a small issue in its CMakeLists, rather than using CMAKE_CURRENT_SOURCE_DIR to get the directory of the current cmakelists, it uses CMAKE_SOURCE_DIR which gets the path of the top level cmakelists the result is that instead of building the .a in its own directory, it will create a bin directory on the top level source directory with the .a inside which is unwanted behaviour since it clutters the directory

a fix would be to replace CMAKE_SOURCE_DIR by CMAKE_CURRENT_SOURCE_DIR

SeleDreams avatar Aug 21 '21 14:08 SeleDreams