godot-cpp icon indicating copy to clipboard operation
godot-cpp copied to clipboard

Rename Vector4.components -> coords.

Open Ivorforce opened this issue 1 year ago • 3 comments

Follow-up of https://github.com/godotengine/godot/pull/97487#pullrequestreview-2331113052 Fixes #1608

As mentioned, a discussion could be had about just removing the 'components' alias, but I think there's no harm just using deprecations as is usually done.

Ivorforce avatar Sep 26 '24 13:09 Ivorforce

Should be made in the same PR, ether we add compatibility or we don't, it should be decided and done in one PR

AThousandShips avatar Sep 26 '24 13:09 AThousandShips

Yes, in the current state of the PR the 'components' union case is retained, with a deprecation note.

Ivorforce avatar Sep 26 '24 13:09 Ivorforce

Parent PR is merged, so we're good to go.

Ivorforce avatar Sep 26 '24 17:09 Ivorforce

I was about to merge this and then realized it's 2 commits. This'll need to be squashed to a single commit before it can merged.

dsnopek avatar Oct 30 '24 13:10 dsnopek

Ok, fixed.

Ivorforce avatar Oct 30 '24 14:10 Ivorforce

Thanks!

dsnopek avatar Oct 30 '24 19:10 dsnopek

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1694

dsnopek avatar Jan 27 '25 22:01 dsnopek

Cherry-picked for 4.3 in PR https://github.com/godotengine/godot-cpp/pull/1695

dsnopek avatar Jan 27 '25 23:01 dsnopek