godot-cpp-template
godot-cpp-template copied to clipboard
Clean up unnecessary compiledb parameters
I found that the compiledb parameter option in SConstruct may be redundant, because the game project is build together with godot-cpp, and there are already related builds and parameters for compiledb in godot-cpp.
So I removed the parameters of computedb and kept an example argument in its place as a replacement.
I am not familiar with Scons, but I accidentally discovered this situation. After comparing the differences after compilation, found that the result (compile_commands. json) is consistent.
Your PR does two things:
- removes compiledb props.
- adds example comments.
I would remove the example comments for now, just for this PR to concentrate on compiledb.
I would remove the example comments for now, just for this PR to concentrate on compiledb.
Thank you for your review. I agree with your suggestion.Thank you!
Does your solution makes the compiledb command for the template code? Like, I know that godot-cpp creates a compile_commands.json, but what my code did was to create compile commands for the local project.
And on another subject, about your last commit, I'm super grateful for the attention, but you don't have to give credit for code reviews. And in the Godot projects, we usually squash the commits to 1 commit, see the docs for more info about this.
Does your solution makes the compiledb command for the template code?
Yes, it will generate compile_commands.json. Because template compilation is call the Scons script of godot-cpp
And I have also merged multi commits into one. Please review again, thank you.
Can confirm the
compiledbparameter still exists on this branch,compile_commands.jsoncan still be generated usingscons compiledb=yes compile_commands.json.
~~I don't get the same results. ./godot-cpp/compile_commands.json is created, but not ./compile_commands.json. The compiledb code in the project is especially there to make the root level definition file.~~
Edit: Nevermind, I called scons inside ./godot-cpp, my bad.
Perfect thanks!
