emacs-gdscript-mode icon indicating copy to clipboard operation
emacs-gdscript-mode copied to clipboard

Address compile warnings

Open jcs090218 opened this issue 5 years ago • 6 comments

I'm getting these warnings when installing this package. Maybe you want to fix it?

Thanks!

In end of data:
gdscript-hydra.el:157:1:Warning: the function `gdscript-hydra--menu/body' is
    not known to be defined.

In gdscript-info-dedenter-opening-block-positions:
gdscript-indent-and-nav.el:755:24:Warning: `seq-contains' is an obsolete
    function (as of 27.1); use `seq-contains-p' instead.

In gdscript-project--select-scene:
gdscript-project.el:52:111:Warning: `format' called with 1 args to fill 0
    format field(s)

In end of data:
gdscript-project.el:115:1:Warning: the function `ag-project-regexp' is not
    known to be defined.

jcs090218 avatar Sep 03 '20 03:09 jcs090218

Weird, makem.sh test doesn't report any error.

seq-contains is normal, we support Emacs 26.3, where seq-contains-p isn't available if I remember right.

The others definitely could use some cleanup.

NathanLovato avatar Sep 03 '20 16:09 NathanLovato

I am using Emacs 27.1 on Windows.

jcs090218 avatar Sep 03 '20 16:09 jcs090218

You were fast! While you were commenting, I removed the initial comment and wrote another.

NathanLovato avatar Sep 03 '20 16:09 NathanLovato

After running tests locally, we should keep in mind that some functions will always cause linting errors but those are fine, like functions relying on ag or projectile. In the code, we check that the user has the optional package before calling into it.

So the lint warnings to address are these two:

In end of data:
gdscript-hydra.el:157:1:Warning: the function `gdscript-hydra--menu/body' is
    not known to be defined.

In gdscript-project--select-scene:
gdscript-project.el:52:111:Warning: `format' called with 1 args to fill 0
    format field(s)

NathanLovato avatar Sep 08 '20 15:09 NathanLovato

I have added the CI in #113. You should able to see warnings here.

jcs090218 avatar May 10 '22 07:05 jcs090218

Just to post some information about makem.sh.

Weird, makem.sh test doesn't report any error.

By read the documentation from their README, it seems like it would only test the package with different linters (package-lint, elsa, etc). Some errors/warnings would only appear in packaging or installing stage, so it's better if you use Cask/Eask in this scenario.

Hope the information helps! :)

jcs090218 avatar May 10 '22 14:05 jcs090218