contact_picker icon indicating copy to clipboard operation
contact_picker copied to clipboard

Read email addresses, phone numbers, postal addresses and instant messaging

Open ened opened this issue 7 years ago • 18 comments
trafficstars

  • the example now links to the simple_permissions plugin in order to gain access to the users address book
  • the dart class now returns a new data structure

ened avatar Jun 27 '18 02:06 ened

Very nice!

rodydavis avatar Jun 27 '18 14:06 rodydavis

BTW, just noticed I left a incorrect simple_permissions dependency in there. Once https://github.com/Ethras/flutter_simple_permissions/pull/19 is merged and a new plugin version is released, I will update the PR.

ened avatar Jun 27 '18 14:06 ened

Sounds great. I had been using a custom contact service plugin and it was such a pain and hack to do what I was wanting with this plugin

rodydavis avatar Jun 27 '18 15:06 rodydavis

@ened I have actually had better luck with simple_permissions instead of flutter_simple_permissions btw

rodydavis avatar Jun 27 '18 15:06 rodydavis

@AppleEducate I believe those two are the same.

ened avatar Jun 28 '18 01:06 ened

@ened I took what you did on your fork and merged the fields from flutter_contacts and updated the example. what do you think? https://github.com/AppleEducate/contact_picker

rodydavis avatar Jun 28 '18 15:06 rodydavis

Very cool! I'll probably get around to review the code on the weekend.

goderbauer avatar Jun 28 '18 19:06 goderbauer

@AppleEducate not sure yet - what is the intention of removing ims, for example? I'd be happy to work on this PR first while keeping the changes as generic as possible.

@goderbauer Do you have comments?

ened avatar Jul 11 '18 01:07 ened

@ened I can try to add it back but it was throwing Everytime a IMS returned with data when I selected a contact. If it was null it didn't crash. It is a weird bug.

I'll clean up the PR

rodydavis avatar Jul 11 '18 02:07 rodydavis

@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August.

ened avatar Jul 11 '18 03:07 ened

Will do. It was also happening on you version too. I will try to find verbose logs because when it happens it does not provide any debug or crash info and just says lost connection to device. If you select a contact without IMS it doesn't crash. I'll keep exploring it

Rody Davis Jr. Full Stack Mobile Developer Github | Website | Appstore | LinkedIn Twitter | Facebook | YouTube On Jul 10, 2018, 11:30 PM -0400, Sebastian Roth [email protected], wrote:

@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rodydavis avatar Jul 11 '18 11:07 rodydavis

Is this pull request ever going to be merged?

GroovinChip avatar Dec 06 '18 15:12 GroovinChip

@ened @goderbauer Is this plugin ever going to get updated? This is a very needed feature by several apps i believe. It would be most appreciated if you could merge this pull request and fix the androidX support. Thanks!

guyzk avatar Mar 10 '19 09:03 guyzk

I’ve been a using my dependency override for quite some time now

rodydavis avatar Mar 10 '19 16:03 rodydavis

I personally oppose this pull request, the beauty of this plugin is to pick your contact without any permission.

I think it's better to create different/separate plugin if you need more detail about the contact with permission.

dexcell avatar Mar 23 '19 18:03 dexcell

I’ll make a separate plugin then, thank you

rodydavis avatar Mar 23 '19 18:03 rodydavis

I’ll make a separate plugin then, thank you

Waiting for an update!!! Thanks!

guyzk avatar Mar 24 '19 14:03 guyzk

@guyzk in the mean time you can use my fork of this plugin! I am already doing this

rodydavis avatar Mar 24 '19 15:03 rodydavis