wc-plugin-framework icon indicating copy to clipboard operation
wc-plugin-framework copied to clipboard

Expiration (MM/YY) cannot be translated

Open antedrnasin opened this issue 4 years ago • 1 comments
trafficstars

UPDATE: I got it to work. the only problem is the "Expiration (MM/YY)" text. It just doesn't work. My guess is that somewhere down the line, during parsing, the SLASH inside that variable is causing it not to be overridden.

antedrnasin avatar Apr 12 '21 07:04 antedrnasin

Hey @antedrnasin is this still an issue? If you are referring to this line in https://github.com/godaddy-wordpress/wc-plugin-framework/blob/b6a17bfc00443ceaa94a1ce8adfe666b15f3f32e/woocommerce/payment-gateway/admin/class-sv-wc-payment-gateway-admin-payment-token-editor.php#L574 it is wrapped in a WP gettext function with the woocommerce-plugin-framework and should be translatable like any other WP string in such context -- I notice however the placeholder attribute is not equally translated: is that the issue you are referring to?

unfulvio-godaddy avatar Apr 19 '23 08:04 unfulvio-godaddy