authentik icon indicating copy to clipboard operation
authentik copied to clipboard

website/integrations: frappe: add trailing slash

Open dominic-r opened this issue 1 year ago • 5 comments

Details

closes #10957


Checklist

  • [ ] Local tests pass (ak test authentik/)
  • [ ] The code has been formatted (make lint-fix)

If an API change has been made

  • [ ] The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • [ ] The code has been formatted (make web)

If applicable

  • [ ] The documentation has been updated
  • [ ] The documentation has been formatted (make website)

dominic-r avatar Aug 23 '24 16:08 dominic-r

Deploy Preview for authentik-storybook canceled.

Name Link
Latest commit 1457ebaa01c7cfbb76f135cbc996bd44e59cf980
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66ce65957079100008a06c16

netlify[bot] avatar Aug 23 '24 16:08 netlify[bot]

Deploy Preview for authentik-docs ready!

Name Link
Latest commit 1457ebaa01c7cfbb76f135cbc996bd44e59cf980
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66ce65966006ba00085e1dc2
Deploy Preview https://deploy-preview-11047--authentik-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 23 '24 16:08 netlify[bot]

didn't notice any changes with the frappe4 png so i didn't change it

cc @tanberry

dominic-r avatar Aug 23 '24 16:08 dominic-r

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.68%. Comparing base (cdbf448) to head (1457eba). Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11047      +/-   ##
==========================================
- Coverage   92.68%   92.68%   -0.01%     
==========================================
  Files         736      736              
  Lines       36426    36426              
==========================================
- Hits        33763    33762       -1     
- Misses       2663     2664       +1     
Flag Coverage Δ
e2e 49.16% <ø> (-0.02%) :arrow_down:
integration 25.01% <ø> (ø)
unit 90.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '24 16:08 codecov[bot]

@tanberry Hi would it be possible to get a status update on this? thanks

dominic-r avatar Aug 27 '24 20:08 dominic-r

@tanberry Hi would it be possible to get a status update on this? thanks

The earlier PR that you edited removed the trailing slash; are we certain we want it added?

tanberry avatar Aug 29 '24 16:08 tanberry

@tanberry im starting to get confused by this and the original pr too. the diff updated a slash by adding it but if it had to be removed and the difference between fixed and old was adding it it was never there? i think im gonna close this for now and the original pr should also by the looks of it

dominic-r avatar Aug 29 '24 18:08 dominic-r